[PER-10311] Implement unlisted share page UI for users without an account #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
==========================================
+ Coverage 46.64% 47.05% +0.40%
==========================================
Files 372 372
Lines 11373 11373
Branches 1881 1881
==========================================
+ Hits 5305 5351 +46
+ Misses 5891 5838 -53
- Partials 177 184 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aasandei-vsp
force-pushed
the
PER-10311-unlisted-share-no-account
branch
2 times, most recently
from
2a2d1dc to
bf19184
Compare
cecilia-donnelly
approved these changes
Oct 14, 2025
Member
cecilia-donnelly
left a comment
cecilia-donnelly
left a comment
There was a problem hiding this comment.
This makes sense to me. For @omnignorant , the main difference here is that we don't show the "Create account" dialog for unlisted shares (for a non-logged-in user).
aasandei-vsp
force-pushed
the
PER-10311-unlisted-share-no-account
branch
from
5ffc978 to
692470b
Compare
Member
|
@omnignorant gave the +1 to merge this without QA. |
aasandei-vsp
force-pushed
the
PER-10311-unlisted-share-no-account
branch
from
692470b to
7cafd9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main story tackled here: https://permanent.atlassian.net/browse/PER-10107
This story was more of a collateral need and has been done in this PR as well: https://permanent.atlassian.net/browse/PER-10306
STEPS TO TEST
OBSERVATION: Unlisted share links will be provided, because as of now we do not have a way of creating unlisted shares from the UI.
Record as unlisted share:
Folder as unlisted share:
Expired unlisted share:
EXTRA TESTS FOR EXISTING SHARE LINK BEHAVIOUR
This tests would be useful to make sure that while developing this new feature, we did not introduce any new bugs or created regressions.
Auto-approve share link:
1 .Create account or sign in to account A
2. Upload a file
3. Create a share link for the uploaded file
4. Copy the link
5. Open a new browser instance
6. Create or sign in to a different account B
8. Paste the link in the browser where the account B is signed in
9. The share link preview will appear, with the "Accept Share" button at the bottom of the screen
Video for reference(can only be viewed in Chrome):
auto-approve-share-link.webm
Request access share link:
1 .Create account or sign in to account A
2. Upload a file
3. Create a share link for the uploaded file
4. Copy the link
5. Open a new browser instance
6. Create or sign in to a different account B
8. Paste the link in the browser where the account B is signed in
9. The share link preview will appear, with the "Request Access" button at the bottom of the screen
Video for reference(can only be viewed in Chrome):
request-access-share-link.webm
Try to access share link with no account:
1 .Create account or sign in to account A
2. Upload a file
3. Create a share link for the uploaded file
4. Copy the link
5. Open a new browser instance in incognito mode
8. Paste the link in the browser
9. The share link preview will appear, with an overlay and a modal asking you to create an account or log in
Video for reference(can only be viewed in Chrome):
no-account-share-link.webm